Page MenuHomePhabricator

Suggested edits module homepage logger interaction data lacks a valid homepage_pageview_token
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Load Special:Homepage
  • Observe analytics requests, in particular the ones using /analytics/legacy/homepagemodule/1.6.7 (there should be one request per homepage module)
  • Observe the "Suggested edits impression" request

What happens?:
The event data lacks a valid value for the homepage_pageview_token property, it's null but the schema only accepts string for this prop

What should have happened instead?:
homepage_pageview_token should be filed with a valid pseudo unique token as a string

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

wmf-23, introduced in rEGRE8d65369e46c67bd0a3f0187b206f6d3107c818dc

Other information (browser name/version, screenshots, etc.):

Event Timeline

Sgs triaged this task as High priority.

Raising priority since we'd like to fix this before train ride.

Change #1133086 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] fix(analytics homepage): pass right params when newing HomepageModuleLogger

https://gerrit.wikimedia.org/r/1133086

Change #1133086 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] fix(analytics homepage): pass right params when newing HomepageModuleLogger

https://gerrit.wikimedia.org/r/1133086

The number of reported errors is close to zero - https://logstash.wikimedia.org/goto/3e50a0a12556181e468073a3e5054a5b. I'm closing the task; will monitor for tomorrow to double-check.

Screen Shot 2025-04-10 at 3.13.23 PM.png (588×2 px, 159 KB)

I'm still occurrences of the error, maybe we only partially fixed it. Will look into it and re-open or file separate task.

I'm still occurrences of the error, maybe we only partially fixed it. Will look into it and re-open or file separate task.

The error rate (homepage_pageview_token":null) ~ 8 errors in 24 hours. Re-opening this ticket since the error rate is not small enough.

Change #1138311 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] fix(SpecialImpact): add missing wgGEHomepagePageviewToken config

https://gerrit.wikimedia.org/r/1138311

The "newing" problem solved in rEGRE4ba11988f5c45b37ddff77de50e4374ea1e80938 has disclosed the issue is still present when user interaction happens in Special:Impact. The JS config var that feeds the client loggers, wgGEHomepagePageviewToken seems only injected in SpecialHomepage.php#97. So I'm at the phase of wondering has this ever worked in Special:Impact?

I have pushed a potential fix, however I'm still missing why we haven't seen such validation errors coming from Special:Impact before? 🤔

Change #1138311 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] fix(Impact module): disable logging if wgGEHomepagePageviewToken is not set

https://gerrit.wikimedia.org/r/1138311

wmf.27 - the last timestamp May 1, 2025 @ 18:27:05 - https://logstash.wikimedia.org/goto/e5638309ba4fb0b38d4195e605945501 (the link is for the last week errors).