Page MenuHomePhabricator
Create Task
Maniphest T379662

[EPIC] Add Codex PHP library to Vendor
Closed, ResolvedPublic
Actions

Description

In order to use Codex PHP inside of MediaWiki, we need to add it to the mediawiki/vendor repo (it can't just be installed using composer require).

For more details see: https://www.mediawiki.org/wiki/Manual:External_libraries

T379800: Application Security Review Request : Codex PHP has been filed to request a security review (which will mostly concern this library's 3rd-party dependencies).

Acceptance Criteria

  • The security review requested at T379800 is complete
  • Any necessary changes from the security review have been addressed
  • Update mediawiki/vendor to add wikimedia/codex at the latest version (currently 0.4.0)
  • Update MW core's composer.json file to match
  • Announce on wikitech-l and in Tech News moved to T399523

Details

SubjectRepoBranchLines +/-
Add wikimedia/codex (Codex PHP) v0.7.1mediawiki/coremaster+3 -0
Add wikimedia/codex v0.7.1 (Codex PHP)mediawiki/vendormaster+15 K -3
composer.json: Add wikimedia/codex to requiremediawiki/coremaster+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 12 2024, 6:01 PM
lwatson set the point value for this task to 1.Nov 12 2024, 6:02 PM
CCiufo-WMF triaged this task as High priority.Nov 12 2024, 6:03 PM
Reedy added a project: MediaWiki-Vendor.Nov 12 2024, 7:47 PM
egardner updated the task description. (Show Details)Nov 12 2024, 11:00 PM
egardner added a subscriber: Dogu.
egardner renamed this task from [placeholder] Add Codex PHP library to Vendor to Add Codex PHP library to Vendor.Nov 12 2024, 11:50 PM
egardner updated the task description. (Show Details)
gerritbot added a comment.Nov 13 2024, 12:14 AM

Change #1087213 had a related patch set uploaded (by Abaris; author: Abaris):

[mediawiki/core@master] composer.json: Add wikimedia/codex to require

https://gerrit.wikimedia.org/r/1087213

gerritbot added a project: Patch-For-Review.Nov 13 2024, 12:14 AM
Dogu updated the task description. (Show Details)Nov 13 2024, 12:15 AM
egardner updated the task description. (Show Details)Nov 13 2024, 6:47 PM
egardner subscribed.

I'm going to set this as blocked pending T379800.

egardner moved this task from Committed to Blocked ⛔ on the Design-System-Team (DST-Sprint-36 (2024-11-11 to 2024-11-22)) board.Nov 13 2024, 6:48 PM
CCiufo-WMF updated the task description. (Show Details)Nov 13 2024, 7:35 PM
Jdforrester-WMF added a subtask: T379800: Application Security Review Request : Codex PHP.Nov 18 2024, 6:03 PM
CCiufo-WMF renamed this task from Add Codex PHP library to Vendor to [EPIC] Add Codex PHP library to Vendor.Nov 18 2024, 8:44 PM
CCiufo-WMF edited projects, added Design-System-Team (Roadmap); removed Design-System-Team (DST-Sprint-36 (2024-11-11 to 2024-11-22)).
CCiufo-WMF removed the point value 1 for this task.
CCiufo-WMF moved this task from Now to Next on the Design-System-Team (Roadmap) board.
Restricted Application added a project: Epic. · View Herald TranscriptNov 18 2024, 8:46 PM
CCiufo-WMF added a subtask: T379862: codex-php test issues.Nov 18 2024, 8:46 PM
egardner mentioned this in T378363: Announce availability of Codex PHP.Nov 22 2024, 7:27 PM
Novem_Linguae subscribed.Nov 26 2024, 12:13 AM
Daimona subscribed.Nov 26 2024, 12:32 AM
malberts subscribed.Nov 26 2024, 10:22 AM
CCiufo-WMF mentioned this in T373708: [EPIC] Create a PHP library for Codex markup generation.Dec 2 2024, 6:23 PM
Krinkle subscribed.Dec 6 2024, 3:45 AM
CCiufo-WMF removed a project: Patch-For-Review.Dec 13 2024, 9:04 AM
Dogu closed subtask T379862: codex-php test issues as Resolved.Dec 14 2024, 6:20 PM
Chlod subscribed.Jan 9 2025, 2:17 AM
Scardenasmolinar subscribed.Jan 9 2025, 2:31 AM
Chlod mentioned this in T153988: Migrate Special:Nuke to Codex.Jan 9 2025, 2:37 AM
sbassett changed the status of subtask T379800: Application Security Review Request : Codex PHP from Open to In Progress.Jan 9 2025, 5:23 PM
MusikAnimal subscribed.Jan 14 2025, 12:01 AM
Chlod mentioned this in T381660: Change Nuke's page list to a table.Jan 14 2025, 11:14 PM
Reedy updated the task description. (Show Details)Jan 22 2025, 10:20 PM
CCiufo-WMF updated the task description. (Show Details)Jan 29 2025, 9:27 PM
CCiufo-WMF updated the task description. (Show Details)Jan 29 2025, 9:31 PM
CCiufo-WMF added a parent task: T377494: [EPIC] Support Moderator Tools with using Codex PHP for Special:Nuke.Jan 30 2025, 6:15 PM
CCiufo-WMF edited parent tasks, added: T153988: Migrate Special:Nuke to Codex; removed: T377494: [EPIC] Support Moderator Tools with using Codex PHP for Special:Nuke.Jan 30 2025, 6:17 PM
Daimona mentioned this in T385612: Replace Mustache templates for Codex components with Codex-PHP in CampaignEvents and WikimediaCampaignEvents.Feb 4 2025, 6:50 PM
Daimona added a parent task: T385612: Replace Mustache templates for Codex components with Codex-PHP in CampaignEvents and WikimediaCampaignEvents.
CCiufo-WMF assigned this task to egardner.Feb 13 2025, 9:06 PM
DTorsani-WMF set the point value for this task to 2.Feb 18 2025, 5:53 PM
DTorsani-WMF edited projects, added Design-System-Team (DST-Sprint-41 (2025-02-17 to 2025-02-28)); removed Design-System-Team (Roadmap).
sbassett closed subtask T379800: Application Security Review Request : Codex PHP as Resolved.Feb 19 2025, 5:09 PM
gerritbot added a comment.Feb 20 2025, 9:23 PM

Change #1087213 abandoned by Abaris:

[mediawiki/core@master] composer.json: Add wikimedia/codex to require

https://gerrit.wikimedia.org/r/1087213

gerritbot added a comment.Feb 24 2025, 11:08 PM

Change #1122262 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/vendor@master] Vendor: Add Codex-PHP v0.6.0

https://gerrit.wikimedia.org/r/1122262

gerritbot added a project: Patch-For-Review.Feb 24 2025, 11:08 PM
gerritbot added a comment.Feb 24 2025, 11:15 PM

Change #1122263 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/core@master] Add wikimedia/codex (Codex PHP) v0.6.0

https://gerrit.wikimedia.org/r/1122263

egardner moved this task from Committed to In Progress on the Design-System-Team (DST-Sprint-41 (2025-02-17 to 2025-02-28)) board.Feb 24 2025, 11:15 PM
egardner moved this task from In Progress to Blocked on the Design-System-Team (DST-Sprint-41 (2025-02-17 to 2025-02-28)) board.Feb 28 2025, 7:16 PM
egardner updated the task description. (Show Details)
egardner added a comment.EditedFeb 28 2025, 7:27 PM

This task is blocked on T227447, but hopefully we will be able to un-block this work soon once this patch in vendor and https://gerrit.wikimedia.org/r/c/design/codex-php/+/1123709 are merged.

Context: Codex PHP currently uses the krinkle/intuition library for handling i18n message strings outside of MW. To add a new composer package to MW vendor, we must also add all of its dependencies. But Intuition is not really intended for use in MW and we don't want to add it to the vendor repo here.

@Dogu just posted a patch to replace Intuition with the new wikimedia/messages library that is hopefully going to be added to the vendor repo shortly.

I am hopeful that these patches can both be merged in the next week or so; at that point I will update the patch that adds Codex PHP to vendor.

CCiufo-WMF changed the task status from Open to Stalled.Mar 3 2025, 6:21 PM
CCiufo-WMF moved this task from DST-Sprint-41 (2025-02-17 to 2025-02-28) to Roadmap on the Design-System-Team board.
CCiufo-WMF edited projects, added Design-System-Team (Roadmap); removed Design-System-Team (DST-Sprint-41 (2025-02-17 to 2025-02-28)).
CCiufo-WMF moved this task from Next to Now on the Design-System-Team (Roadmap) board.
CCiufo-WMF removed a project: Patch-For-Review.
CCiufo-WMF removed the point value 2 for this task.
egardner added a subtask: T227447: Librarize i18n-related PHP classes in MediaWiki.Mar 3 2025, 7:20 PM
CCiufo-WMF moved this task from Now to Next on the Design-System-Team (Roadmap) board.Mar 4 2025, 4:10 PM
CCiufo-WMF added a parent task: T377494: [EPIC] Support Moderator Tools with using Codex PHP for Special:Nuke.Mar 17 2025, 5:56 PM
Samwilson mentioned this in T349828: Make use of Codex within Page Forms.May 19 2025, 5:08 AM
Lucas_Werkmeister_WMDE mentioned this in T395802: [MEX] Prototype server-side rendering.Jun 2 2025, 1:26 PM
kostajh subscribed.Jun 12 2025, 12:53 PM
MusikAnimal mentioned this in rECOR4958eff4c066: SpecialWishlistIntake: move saving of wishes to the server.Jun 16 2025, 8:04 PM
MusikAnimal mentioned this in rECOR0ee81bbb8126: Render wishes server-side instead of through the template.Thu, Jun 26, 1:40 AM
CCiufo-WMF added a project: Codex.Wed, Jul 2, 4:03 PM
Restricted Application edited projects, added Design-System-Team; removed Design-System-Team (Roadmap). · View Herald TranscriptWed, Jul 2, 4:03 PM
CCiufo-WMF removed egardner as the assignee of this task.Wed, Jul 2, 4:06 PM
CCiufo-WMF moved this task from Inbox to Roadmap on the Design-System-Team board.
CCiufo-WMF edited projects, added Design-System-Team (Roadmap); removed Design-System-Team.
Catrope claimed this task.Wed, Jul 9, 4:58 PM
Catrope moved this task from Backlog to Upcoming on the Codex board.
Catrope moved this task from Upcoming to Code Review on the Codex board.
gerritbot added a comment.Mon, Jul 14, 4:22 PM

Change #1122262 merged by jenkins-bot:

[mediawiki/vendor@master] Add wikimedia/codex v0.7.1 (Codex PHP)

https://gerrit.wikimedia.org/r/1122262

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.10; 2025-07-15).Mon, Jul 14, 5:00 PM
Jdforrester-WMF updated the task description. (Show Details)Mon, Jul 14, 5:46 PM
gerritbot added a comment.Mon, Jul 14, 9:42 PM

Change #1122263 merged by jenkins-bot:

[mediawiki/core@master] Add wikimedia/codex (Codex PHP) v0.7.1

https://gerrit.wikimedia.org/r/1122263

Dogu updated the task description. (Show Details)Mon, Jul 14, 10:26 PM
Dogu updated the task description. (Show Details)
Catrope closed subtask T387780: Codex PHP: Remove krinkle/intuition dependency as Declined.Tue, Jul 15, 12:03 AM
Catrope removed a subtask: T227447: Librarize i18n-related PHP classes in MediaWiki.
Catrope closed this task as Resolved.Tue, Jul 15, 12:47 AM
Catrope updated the task description. (Show Details)
Catrope updated the task description. (Show Details)

Closing this task because Codex-PHP has been added to MW core and MW vendor. Announcing it (and the additional work we need to do before we can do that) is tracked separately as T399523.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits