Page MenuHomePhabricator

Stop showing create an account message on Lexeme editing UI for Wikibase instances that have temporary accounts enabled
Closed, ResolvedPublic

Description

Problem:
We are showing warnings when edits are made on Lexemes and the user isn't logged in. This warning promps them to create an account or log in. With IP Masking this will no longer be required as we will be defering to a media wiki status bar: https://phabricator.wikimedia.org/T330510

This should apply for all edits to Lexemes.

Example:

image.png (134×325 px, 11 KB)

When editing: https://wikidata.beta.wmflabs.org/wiki/Lexeme:L57498 this warning box appears.

This warning box and message on a Lexeme page should be removed when editing a Lexeme and IP masking is enabled and the user isn't logged in.

But the warning should remain as is on wikis that don't have IP masking enabled e.g. 3rd party Wikibases

BDD
GIVEN a Lexeme
AND a user who isn't logged in
WHEN making an edit
AND IP Masking is enabled
THEN do not show the "create an account" prompt

Acceptance criteria:

  • "Create an account" prompt isn't shown when editing Lexemes when IP Masking is enabled

Event Timeline

Arian_Bozorg renamed this task from Stop showing IP warning on Lexeme pages for Wikibase instances that have temporary accounts enabled to Stop showing IP warning on Lexeme editing UI for Wikibase instances that have temporary accounts enabled.Jan 12 2024, 2:59 PM
Arian_Bozorg updated the task description. (Show Details)
Arian_Bozorg renamed this task from Stop showing IP warning on Lexeme editing UI for Wikibase instances that have temporary accounts enabled to Stop showing create an account message on Lexeme editing UI for Wikibase instances that have temporary accounts enabled.Jan 17 2024, 11:47 AM
Arian_Bozorg updated the task description. (Show Details)

Just adding my response on the other ticket here as well:
With Wikimedia products moving over to Vector 2022, Wikidata will probably make that transition this year as well. This would mean there would be only a small window of time between the temporary accounts and the move to Vector 2022.

So in this case with the login / sign-up warning, let's continue with this ticket and remove them for Wikibase instances that have temporary accounts enabled.

Change 993057 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Remove anonymous edit pop-up warning for TempUsers

https://gerrit.wikimedia.org/r/993057

Change 993057 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove anonymous edit pop-up warning for TempUsers

https://gerrit.wikimedia.org/r/993057

Arian_Bozorg claimed this task.

Thanks so much! Looks good to me :)