Thumb styling on the file description page and other callers of makeThumbLinkObj
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Arlolra
	May 30 2023, 11:54 PM

Description

Of note so far,

includes/page/ImagePage.php is missing the module (from T337794#8890676)
mw-content-ltr / mw-content-rtl isn't applied, so some default styling isn't rendered (text-align, etc)

Details

Subject	Repo	Branch	Lines +/-
Copy upstream changes for thumb styling on file desc page	mediawiki/skins/Timeless	master	+26 -2
Style thumbs in places that don't set a content language	mediawiki/skins/MinervaNeue	master	+10 -2
Fix thumb styling on file description page	mediawiki/core	wmf/1.41.0-wmf.13	+31 -4
Fix thumb styling on file description page	mediawiki/core	master	+31 -4

Customize query in gerrit

Related Objects

Mentioned Here: T337794: Error: Call to a member function getOutput() on null

Event Timeline

Arlolra created this task.May 30 2023, 11:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 30 2023, 11:54 PM

Arlolra claimed this task.May 31 2023, 10:22 PM

Arlolra triaged this task as Medium priority.

Arlolra added a project: Content-Transform-Team-WIP.

Arlolra moved this task from Needs Triage to Media Structure on the Parsoid board.

Arlolra moved this task from Backlog to In Progress on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.

Arlolra moved this task from Backlog to In Progress on the Content-Transform-Team-WIP board.

Change 925086 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] [WIP] Thumb styling on file description page

https://gerrit.wikimedia.org/r/925086

gerritbot added a project: Patch-For-Review.May 31 2023, 11:27 PM

Arlolra moved this task from In Progress to Code Review on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.Jun 14 2023, 3:33 PM

Arlolra moved this task from In Progress to Code Review on the Content-Transform-Team-WIP board.

Arlolra moved this task from Code Review to To Deploy on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.Jun 14 2023, 7:36 PM

Arlolra moved this task from Code Review to To Deploy on the Content-Transform-Team-WIP board.

Change 925086 merged by jenkins-bot:

[mediawiki/core@master] Fix thumb styling on file description page

https://gerrit.wikimedia.org/r/925086

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 14 2023, 8:00 PM

Change 930240 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/skins/MinervaNeue@master] Style thumbs in places that don't set a content language

https://gerrit.wikimedia.org/r/930240

Change 930249 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@wmf/1.41.0-wmf.13] Fix thumb styling on file description page

https://gerrit.wikimedia.org/r/930249

Change 930249 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.13] Fix thumb styling on file description page

https://gerrit.wikimedia.org/r/930249

Mentioned in SAL (#wikimedia-operations) [2023-06-14T20:52:07Z] <taavi@deploy1002> Started scap: Backport for [[gerrit:930249|Fix thumb styling on file description page (T337804)]]

Mentioned in SAL (#wikimedia-operations) [2023-06-14T20:54:25Z] <taavi@deploy1002> arlolra and taavi: Backport for [[gerrit:930249|Fix thumb styling on file description page (T337804)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.13; 2023-06-13); removed MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 14 2023, 9:00 PM

Arlolra moved this task from To Deploy to To Verify on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.Jun 14 2023, 9:01 PM

Arlolra moved this task from To Deploy to To Verify on the Content-Transform-Team-WIP board.

Mentioned in SAL (#wikimedia-operations) [2023-06-14T21:02:52Z] <taavi@deploy1002> Finished scap: Backport for [[gerrit:930249|Fix thumb styling on file description page (T337804)]] (duration: 10m 44s)

Arlolra closed this task as Resolved.Jun 14 2023, 9:06 PM

Change 930240 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Style thumbs in places that don't set a content language

https://gerrit.wikimedia.org/r/930240

Maintenance_bot removed a project: Patch-For-Review.Jun 14 2023, 10:31 PM

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.15; 2023-06-27); removed MW-1.41-notes (1.41.0-wmf.13; 2023-06-13).Jun 14 2023, 11:00 PM

Change 930273 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/skins/Timeless@master] Copy upstream changes for thumb styling on file desc page

https://gerrit.wikimedia.org/r/930273

gerritbot added a project: Patch-For-Review.Jun 14 2023, 11:08 PM

Change 930273 merged by jenkins-bot: