Page MenuHomePhabricator

SX: Translation is not reset after discarding it and going back to dashboard
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  1. Go to Section Translation application (test wiki)
  2. Select a page or section to translate and move forward to the "Pick a sentence" step
  3. Translate some sentences.
  4. Click on the back arrow on the top left of the page
  5. Inside the dashboard (where you should be redirected from the previous step) select the same article/section to translate and move forward again to the "Pick a sentence" step

What happens?:
The section contents appear with the previously translated sentences present.

What should have happened instead?:
The section should not be translated at all and the previous translation should have been reset.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Change 905575 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX: Add "reset" methods to page section, subsection and sentence models

https://gerrit.wikimedia.org/r/905575

Change 905577 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX: Reset translation before going back to dashboard

https://gerrit.wikimedia.org/r/905577

Change 905591 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX instrumentation: Always take "campaign" URL parameter into account

https://gerrit.wikimedia.org/r/905591

Change 905575 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Add "reset" methods to page section, subsection and sentence models

https://gerrit.wikimedia.org/r/905575

Change 905577 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Reset translation before going back to dashboard

https://gerrit.wikimedia.org/r/905577

Change 907436 had a related patch set uploaded (by Nik Gkountas; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20230410

https://gerrit.wikimedia.org/r/907436

Change 907436 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20230410

https://gerrit.wikimedia.org/r/907436

The intended behaviour is more nuanced than what the ticket describes and seems to implement. In the described scenario:

  • If there is an in-progress translation for the same article/section, the expected behaviour is for the in-progress contents to load when the user tries to start a new article/section.
  • If there is no in-progress translation (not started before, or was deleted by the user)
    • In this case it is very important to test the case where there was an in-progress translation that the user deleted before trying to start the new version.