Maniphest T318716

🥦️ Handle `If-Match` header for GET requests
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ollie.Shotton_WMDE
	Sep 27 2022, 2:12 PM

Tags

Referenced Files

None

Subscribers

Ollie.Shotton_WMDE

Description

Change OAS definition according to the "What we want" table (E18-E21 and G18-G21)
Change the RequestPreconditionCheck to trigger status code 200 instead of 412 if the If-Match header condition is met

Details

	Subject	Repo	Branch	Lines +/-
	REST: Add 'If-Match' e2e tests for GET requests	mediawiki/extensions/Wikibase	master	+56 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		WMDE-leszek	T318221 🥦️ Handle conditional http headers in Wikibase REST API
		Resolved		Silvan_WMDE	T318716 🥦️ Handle `If-Match` header for GET requests

Event Timeline

Ollie.Shotton_WMDE created this task.Sep 27 2022, 2:12 PM

Silvan_WMDE mentioned this in T318221: 🥦️ Handle conditional http headers in Wikibase REST API.Sep 28 2022, 11:12 AM

Jakob_WMDE mentioned this in T318796: 🥦️ Handle `If-Unmodified-Since` header for get requests.Sep 28 2022, 3:33 PM

Jakob_WMDE mentioned this in T318715: 🥦️ Cross check "What we want" table against RFC 9110.Sep 28 2022, 4:09 PM

Silvan_WMDE claimed this task.Sep 29 2022, 3:18 PM

Silvan_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 14) board.

Change 838776 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] REST: Handle 'If-Match' header for GET requests

https://gerrit.wikimedia.org/r/838776

gerritbot added a project: Patch-For-Review.Oct 5 2022, 11:31 AM

Silvan_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 14) board.Oct 6 2022, 2:02 PM

Change 838776 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Add 'If-Match' e2e tests for GET requests

https://gerrit.wikimedia.org/r/838776

Maintenance_bot removed a project: Patch-For-Review.Oct 6 2022, 4:30 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.5; 2022-10-10).Oct 6 2022, 5:00 PM

Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 14) board.Oct 7 2022, 7:33 AM

WMDE-leszek closed this task as Resolved.Oct 14 2022, 12:57 PM