Initially
Opening the Story Viewer
You can notice the background left and right padding move
The background shouldn't move
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix background glitch when opening Story Viewer | mediawiki/extensions/Wikistories | master | +1 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T318895 Image/ Visual Enhancements on Wikistories | |||
| Resolved | hueitan | T318627 Background glitch when opening Story Viewer |
Event Timeline
Comment Actions
This is caused by the recent change of T309043: A reader can scroll an article while reading a story.
in this commit https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikistories/+/822032/
Comment Actions
Change 838802 had a related patch set uploaded (by Huei Tan; author: Huei Tan):
[mediawiki/extensions/Wikistories@master] Fix background glitch when opening Story Viewer
Comment Actions
To reviewer:
Please test this carefully on Desktop/Mobile browser, when the story viewer is opened,
- The user shouldn't be able to scroll the site background article content;
- The user shouldn't see the background content glitch;
Comment Actions
Change 838802 merged by jenkins-bot:
[mediawiki/extensions/Wikistories@master] Fix background glitch when opening Story Viewer
Comment Actions
Tested on Safari v16, Firefox v105 and Chrome v106 and Chrome mobile browser on an Android device.
I cannot scroll the background and neither do I see any glitches.