Page MenuHomePhabricator

Support long section exclusion lists for link recommendations
Closed, ResolvedPublic

Description

We machine.generate lists of likely section names to be used for T304150: Allow communities to configure which sections are excluded from link suggestion generation. These lists can get quite long and easily exceed the URL length limit when provided as a GET parameter (which is currently the case).

Event Timeline

Change 791085 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[operations/mediawiki-config@master] Temporarily disable link recommendation backend on hi, uk

https://gerrit.wikimedia.org/r/791085

Change 791086 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[research/mwaddlink@main] Move sections_to_exclude to POST body

https://gerrit.wikimedia.org/r/791086

Change 791087 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Send sections_to_exclude in the POST body

https://gerrit.wikimedia.org/r/791087

Change 791089 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[operations/mediawiki-config@master] Revert "Temporarily disable link recommendation backend on hi, uk"

https://gerrit.wikimedia.org/r/791089

kostajh triaged this task as Medium priority.May 12 2022, 8:57 AM

Change 791086 merged by jenkins-bot:

[research/mwaddlink@main] Move sections_to_exclude to POST body

https://gerrit.wikimedia.org/r/791086

Change 791251 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.10] Send sections_to_exclude in the POST body

https://gerrit.wikimedia.org/r/791251

Change 791322 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/deployment-charts@master] linkrecommendation: Bump version

https://gerrit.wikimedia.org/r/791322

Change 791340 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[research/mwaddlink@main] Fix section exclusion POST body handling

https://gerrit.wikimedia.org/r/791340

Change 791087 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Send sections_to_exclude in the POST body

https://gerrit.wikimedia.org/r/791087

Change 791085 abandoned by Gergő Tisza:

[operations/mediawiki-config@master] Temporarily disable link recommendation backend on hi, uk

Reason:

not actually needed, see Ife6f98459fcee802cec8126044681b8a10f65389

https://gerrit.wikimedia.org/r/791085

Change 791089 abandoned by Gergő Tisza:

[operations/mediawiki-config@master] Revert "Temporarily disable link recommendation backend on hi, uk"

Reason:

not actually needed, see Ife6f98459fcee802cec8126044681b8a10f65389

https://gerrit.wikimedia.org/r/791089

Change 791340 merged by jenkins-bot:

[research/mwaddlink@main] Fix section exclusion POST body handling

https://gerrit.wikimedia.org/r/791340

Change 791322 merged by jenkins-bot:

[operations/deployment-charts@master] linkrecommendation: Bump version

https://gerrit.wikimedia.org/r/791322

Change 791251 merged by Gergő Tisza:

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.10] Send sections_to_exclude in the POST body

https://gerrit.wikimedia.org/r/791251

Mentioned in SAL (#wikimedia-operations) [2022-05-12T13:37:07Z] <tgr@deploy1002> Synchronized php-1.39.0-wmf.10/extensions/GrowthExperiments/includes/NewcomerTasks/AddLink/ServiceLinkRecommendationProvider.php: Backport: [[gerrit:791251|Send sections_to_exclude in the POST body (T308186)]] (duration: 00m 49s)

Tgr added a subscriber: Trizek-WMF.

Note that this was a case of T307402: Maintenance scripts should consistently log errors - we only noticed the script is consistently failing on certain wikis because @Trizek-WMF manually checked them (thanks!).