Seen on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Score/+/760255/3/includes/Score.php
https://integration.wikimedia.org/ci/job/mwext-php72-phan-docker/162095/console
17:14:11 includes/Score.php:246 PhanPossiblyUndeclaredVariable Variable $wgUploadDirectory is possibly undeclared
and code
global $wgScoreDirectory, $wgUploadDirectory; if ( $wgScoreDirectory === false ) { $dir = "{$wgUploadDirectory}/lilypond"; } else { $dir = $wgScoreDirectory; }
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| build: Update mediawiki/mediawiki-phan-config to 0.12.0 | mediawiki/extensions/Score | master | +1 -2 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Daimona | T301079 PhanPossiblyUndeclaredVariable false positive | |||
| Resolved | Daimona | T298576 Upgrade phan to 5.3.2 or later | |||
| Resolved | Daimona | T311452 Taint Check Plugin release |
This is a known issue, already fixed in phan master after https://github.com/phan/phan/issues/4539. My suggestion is to suppress the issue, so the suppression can be removed as soon as T298576 is done and LibUp runs.
Similar false positiv showed up in Flow, suppressed with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Flow/+/761771/.
Change 840285 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/extensions/Score@master] build: Update mediawiki/mediawiki-phan-config to 0.12.0
Change 840285 merged by jenkins-bot:
[mediawiki/extensions/Score@master] build: Update mediawiki/mediawiki-phan-config to 0.12.0