Skip to content

Fix wrong example in README. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2015
Merged

Fix wrong example in README. #1

merged 1 commit into from
Jul 20, 2015

Conversation

gedex
Copy link
Member

@gedex gedex commented Jul 20, 2015

The returned method should be Response object instead of Request object.

@gedex
Fix wrong example in README.
057b251 
The returned method should be Response object instead of Request object.
@claudiosanches
Copy link
Contributor

I just want keep wcapi because I used it as example in line 34

@gedex
Copy link
Member Author

gedex commented Jul 20, 2015

Your wcapi example in line 34 is perect. I was referring example that follows after that, for instance:

>>> wcapi.get("products")
>>> wcapi.status_code
200

would raise AttributeError because API object doesn't have status_code attribute.

@claudiosanches
Copy link
Contributor

But why you change the examples? :p

-    >>> wcapi.status_code
+    >>> r = wcapi.get("products")

@claudiosanches
Copy link
Contributor

Ohh yeah xD
Now I get!

claudiosanches added a commit that referenced this pull request Jul 20, 2015
@claudiosanches
Merge pull request #1 from gedex/fix-readme-example
f1f91d2 
Fix wrong example in README.
@claudiosanches claudiosanches merged commit f1f91d2 into woocommerce:master Jul 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gedex @claudiosanches