docs: sync vite need node version #3263
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| @@ -23,7 +23,7 @@ import { VTCodeGroup, VTCodeGroupTab } from '@vue/theme' | |||
| :::tip Prerequisites | |||
|
|
|||
| - Familiarity with the command line | |||
| - Install [Node.js](https://nodejs.org/) version 18.3 or higher | |||
| - Install [Node.js](https://nodejs.org/) version `^20.19.0 || >=22.12.0` | |||
There was a problem hiding this comment.
question: would any version higher than 20.19 work? It's better to avoid using logical operators in quick start and try to phrase it with words
There was a problem hiding this comment.
It seems that this is not the case. In order to ensure that require(esm) is OK, vite7 adjusts the required node version to this. refer to vitejs/vite#19972 (comment) https://nodejs.org/api/modules.html#loading-ecmascript-modules-using-require
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
The vite version currently supported by create-vue is 7, and the node version required by vite is as follows. In order to ensure that the created project is OK, you need to synchronize the node version information.
https://github.com/vitejs/vite/blob/588b3b5a44eef35bcca0e3079df579d50a528421/package.json#L6
Proposed Solution
Additional Information