Experimental Vim9 support #443
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Add a spec for case-in pattern matching Only consider `in` at the beginning of a line Fix indentation for `in` keyword Fix tag maps Include "" and "." in 'path' Avoid recursively triggering in tag/file maps Prevent endless defs from starting a method region Add highlighting for shareable_constant_value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not planning to merge this, just playing around. Changes were mostly mechanical, so it wasn't a big deal to apply. I might do something like keep both versions of the code in separate files and if-clause them, which might actually make it mergeable.
Performance-wise, I tested on a particularly annoying edge case, a list of 199 entries that looks like this:
Every indent needs to find the "most significant line" with a linear search, going through every line above until the
[. Anyway, here's a result ofprofile func GetRubyIndenton master:And here it is when it calls the vim9 function:
It's nothing too dramatic, but it's not nothing, I guess.