Startup Java Project Configuration #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgebal
reviewed
Apr 8, 2017
|
Yes, is better to keep the IDE files out. |
jgebal
approved these changes
Apr 8, 2017
| <dependencies> | ||
| <dependency> | ||
| <groupId>com.oracle.jdbc</groupId> | ||
| <artifactId>ojdbc7</artifactId> |
There was a problem hiding this comment.
Should we use java7 driver or go ahead with java8?
Maybe entire project should be build on java7?
Or do we want 2 separate builds with java7 and java8?
There was a problem hiding this comment.
I would prefer to use Java 8 because of lambda expressions and try with resources. But if we want to support both drivers, we can't use those new features anyways.
We could start with the Java 7 and add support to the newest later.
What do you think?
There was a problem hiding this comment.
Sounds good to me.
Probably for Java8 we will need a separate branch/project then :(
|
Merging to start working on base repo, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Startup project using maven and travis.