Skip to content

Feature/version check #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Nov 10, 2017
Merged

Feature/version check #28

merged 17 commits into from
Nov 10, 2017

Conversation

pesse
Copy link
Member

@pesse pesse commented Nov 10, 2017

Including everything needed for compatibility check.

Samuel Nitsche and others added 17 commits October 29, 2017 14:14
not sufficient though, we want to have a more specific check with fallback-mechanisms for some features
Also added some tests for getting Framework version and fixed error in getting it
As discussed in slack channel the goal is to have the most actual API
version be compatible with the major version of the framework.
API of a higher version should always be downwards compatible inside
the same major version.
had to restructure current code a bit to support different implementations of TestRunner calls
API should now be able to work for Framework-version 3.0.0 - 3.0.3
If check is skipped, the API expects the latest framework version to be present
- TestRunnerStatement-Implementations are now hidden from public
- DatabaseNotCompatibleException now uses Version-objects instead of strings
- Version now contains a getNormalizedVersion()-method and it's
toString()-method returns the original version string
@pesse pesse merged commit 6bdd4f9 into develop Nov 10, 2017
@pesse pesse removed the in progress label Nov 10, 2017
@pesse pesse deleted the feature/version_check branch November 10, 2017 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants