Add caching + defer the service provider #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cache the password list for future re-use so it doesn’t need to be re-computed every time
src/DumbPasswordServiceProvider.php
Outdated
| Validator::extend('dumbpwd', function ($attribute, $value, $parameters, $validator) { | ||
| $path = realpath(__DIR__ . '/../resources/config/passwordlist.txt'); | ||
| $cache_key = md5_file($path); | ||
| $data = Cache::rememberForever('dumbpwd_list_' . $cache_key, function () use ($path) { |
There was a problem hiding this comment.
Where is the Cache Facade being imported? or would you rather use the cache helper function?
There was a problem hiding this comment.
oops. i had added it in the project I tested this in, but not the fresh clone of the repo. fix incoming!
There was a problem hiding this comment.
thanks for catching it
|
@jkudish Thanks for the PR. This is beautiful. Merging right away!! |
|
Awesome. Thanks!
…On Tue, Apr 25, 2017, 9:22 PM Prosper Otemuyiwa ***@***.***> wrote:
Merged #13 <#13>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAP4nVAKKbwggGbyEv9rFjH69DaavhZtks5rzsZ2gaJpZM4NILDa>
.
|
|
@jkudish What's your twitter handle? I want to praise you there 😄 |
|
I think you found it! 👍 Thanks for the speedy release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon #12 to further improve the performance of this service provider:
rememberForeverand an md5 hash of the file as the key, so that the file doesn't need to be re-read and re-computed every time.Let me know what you think 👍