Flip the array of passwords before turning it into a collection #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If flipped after it's been made into a collection, then 2 collections exist in memory, and with 10k items, that consumes a lot of memory. Instead, this performs the flip before it puts into a collection
|
Closing, #12 is a better approach IMO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If flipped after it's been made into a collection, then 2 collections exist in memory, and with 10k items, that consumes a lot of memory. Instead, this performs the flip before it puts into a collection.
Fixes #10
I'll also look into caching the array in a separate PR