Skip to content

use is_alphanumeric from std #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

PSeitz
Copy link

@PSeitz PSeitz commented Jul 14, 2025

use is_alphanumeric from std and update unicode.py to remove obsolete
parts
closes #148

use is_alphanumeric from std and update unicode.py to remove obsolete
parts
closes unicode-rs#148
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. No, this cannot rely on std: there is no guarantee this crate and libstd have the same Unicode version, and that matters for algorithm correctness. You don't want to mix data from different versions.

@PSeitz
Copy link
Author

PSeitz commented Jul 15, 2025

Ah okay that makes sense

@PSeitz PSeitz closed this Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace tables.rs with std lib
3 participants