Impl pretty-printing for AugmentedScriptSet #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
reviewed
Jun 10, 2020
src/mixed_script.rs
Outdated
| impl Debug for AugmentedScriptSet { | ||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| if self.is_empty() { | ||
| write!(f, "AugmentedScriptSet{{∅}}")?; |
There was a problem hiding this comment.
Can we have a space after the name?
src/mixed_script.rs
Outdated
| let hanb = if self.hanb { Some("Hanb") } else { None }; | ||
| let jpan = if self.jpan { Some("Jpan") } else { None }; | ||
| let kore = if self.kore { Some("Kore") } else { None }; | ||
| for writing_system in None.into_iter().chain(hanb).chain(jpan).chain(kore) { |
There was a problem hiding this comment.
we can just chain an base.iter.map(Script::short_name) here
src/mixed_script.rs
Outdated
| //for script in self.hanb | ||
| write!(f, "}}")?; | ||
| } | ||
| //if self.base.is_common() || self.base.is_ |
src/restriction_level.rs
Outdated
| @@ -58,13 +58,21 @@ impl RestrictionLevelDetection for &'_ str { | |||
| } | |||
| } | |||
|
|
|||
| fn single_item<I: Iterator>(mut iter: I) -> Option<I::Item> { | |||
There was a problem hiding this comment.
Can we instead implement this via count_ones()?
There was a problem hiding this comment.
Do you mean accessing the bitset underlying ScriptExtension directly? We cannot access the implementation detail from this crate...
There was a problem hiding this comment.
Right, add that to the original crate. Maybe a len() method
There was a problem hiding this comment.
There was a problem hiding this comment.
The PR is merged, now we need a new release of that crate.
src/mixed_script.rs
Outdated
| @@ -67,14 +65,50 @@ impl From<&'_ str> for AugmentedScriptSet { | |||
| impl Default for AugmentedScriptSet { | |||
| fn default() -> Self { | |||
| AugmentedScriptSet { | |||
| base: ScriptExtension::Single(Script::Common), | |||
| base: ScriptExtension::from(Script::Common), | |||
|
Rebased and addressed the review comments. |
This was referenced Jun 12, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.