CLDR-18798 bad locales: call out bad locales in user list #4878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we are already normalizing away 'bad' (invalid or missing locales) from the user list - this code _preserves_ anything that was normalized away and presents it in the user list - error can be corrected by calling 'set locales' and changing the locales, as the 'set locale' function will overwrite the locales list and does not allow invalid or missing locales to be set.
srl295
requested review from
conradarcturus,
macchiati,
AEApple,
btangmu and
DraganBesevic
btangmu
approved these changes
Jul 16, 2025
| @@ -451,6 +451,7 @@ private void putShownUser(JSONArray shownUsers, UserSettings u) throws JSONExcep | |||
| boolean havePermToChange = me.isAdminFor(user); | |||
| boolean userCanDeleteUser = UserRegistry.userCanDeleteUser(me, user.id, user.userlevel); | |||
| VoteResolver.Level level = VoteResolver.Level.fromSTLevel(user.userlevel); | |||
| // TODO: why doesn't this use u.toJSONObject()? | |||
There was a problem hiding this comment.
"TODO" comment should include a ticket number
There was a problem hiding this comment.
good. i'll update this in a followon
|
I ran across two other locale codes that should not occur — nobody should be able to vote in them. Norwegian Bokmål nb → should be no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-18798
ALLOW_MANY_COMMITS=true