CLDR-18697 New PathStarrer.getWithPattern; make STAR_PATTERN private #4877
+46
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-New getWithPattern gets default starred path, then replaces STAR_PATTERN with given pattern -Use getWithPattern in GenerateEnglishChanged and ShowStarredCoverage -Assume STAR_PATTERN would never occur (literally, not as regex) in an unstarred path -Make STAR_PATTERN private for encapsulation, leaving open options for refactoring -Fix compiler warnings in GenerateEnglishChanged, mostly automatic refactoring -Comments
|
I confirmed that GenerateEnglishChanged produces same output as before |
|
The next steps would be to replace remaining |
macchiati
approved these changes
Jul 16, 2025
srl295
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-New getWithPattern gets default starred path, then replaces STAR_PATTERN with given pattern
-Use getWithPattern in GenerateEnglishChanged and ShowStarredCoverage
-Assume STAR_PATTERN would never occur (literally, not as regex) in an unstarred path
-Make STAR_PATTERN private for encapsulation, leaving open options for refactoring
-Fix compiler warnings in GenerateEnglishChanged, mostly automatic refactoring
-Comments
CLDR-18697
ALLOW_MANY_COMMITS=true