Skip to content

CLDR-18745 update validate_currencies.py #4870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

CLDR-18745 update validate_currencies.py #4870

merged 1 commit into from
Jul 14, 2025

Conversation

preetsojitra2712
Copy link
Contributor

CLDR-18745

  • Updates validate_currencies.py to collect all displayName-count-* fields

  • Breaks each locale’s currency lines into 5-item chunks for the LLM

  • Runs “Check correctness” and “Find missing symbols” prompts

  • Emits a JSON report with the AI results and a local count

  • This PR completes the ticket.

preetsojitra2712 added a commit to preetsojitra2712/cldr that referenced this pull request Jul 11, 2025
@preetsojitra2712
CLDR-18745 update validate_currencies.py
79a66eb 
See unicode-org#4870
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

preetsojitra2712 added a commit to preetsojitra2712/cldr that referenced this pull request Jul 11, 2025
@preetsojitra2712
CLDR-18745 update validate_currencies.py
3ef21eb 
See unicode-org#4870
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@preetsojitra2712
Copy link
Contributor Author

Thanks for the feedback, @younies I’ll follow up with a PR that updates flatten() to collect all displayName-count-* entries into a list and include a sample JSON output for you to review.

@preetsojitra2712
Copy link
Contributor Author

preetsojitra2712 commented Jul 11, 2025 •
edited
Loading

Hello @younies ,

I got this error in our Docker/WebDriver CI job:

unknown error: net::ERR_CONNECTION_REFUSED

It’s happening because the CLDR app never starts before Selenium runs, so the browser can’t connect. Additionally, our setup-config.sh has a typo (Usage::), is missing -f when removing the jar, and has a bad expr call.

@younies younies self-requested a review July 12, 2025 14:15
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@younies younies merged commit e3d9d5d into unicode-org:main Jul 14, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younies younies younies approved these changes

Assignees

@preetsojitra2712 preetsojitra2712

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@preetsojitra2712 @younies