typescript-eslint · bradzacher · Jun 4, 2024 · Jun 3, 2024 · Jun 3, 2024 · Jun 3, 2024
diff --git a/...on/TSImportEqualsDeclaration/fixtures/_error_/external-module-ref-non-string-2/fixture.ts b/...on/TSImportEqualsDeclaration/fixtures/_error_/external-module-ref-non-string-2/fixture.ts
@@ -0,0 +1 @@
+import F = require(1 + 1);
diff --git a/...aration/fixtures/_error_/external-module-ref-non-string-2/snapshots/1-TSESTree-Error.shot b/...aration/fixtures/_error_/external-module-ref-non-string-2/snapshots/1-TSESTree-Error.shot
diff --git a/...eclaration/fixtures/_error_/external-module-ref-non-string-2/snapshots/2-Babel-Error.shot b/...eclaration/fixtures/_error_/external-module-ref-non-string-2/snapshots/2-Babel-Error.shot
diff --git a/...ration/fixtures/_error_/external-module-ref-non-string-2/snapshots/3-Alignment-Error.shot b/...ration/fixtures/_error_/external-module-ref-non-string-2/snapshots/3-Alignment-Error.shot
diff --git a/...on/TSImportEqualsDeclaration/fixtures/_error_/external-module-ref-non-string-3/fixture.ts b/...on/TSImportEqualsDeclaration/fixtures/_error_/external-module-ref-non-string-3/fixture.ts
@@ -0,0 +1 @@
+import F = require(`1`);
diff --git a/...aration/fixtures/_error_/external-module-ref-non-string-3/snapshots/1-TSESTree-Error.shot b/...aration/fixtures/_error_/external-module-ref-non-string-3/snapshots/1-TSESTree-Error.shot
diff --git a/...eclaration/fixtures/_error_/external-module-ref-non-string-3/snapshots/2-Babel-Error.shot b/...eclaration/fixtures/_error_/external-module-ref-non-string-3/snapshots/2-Babel-Error.shot
diff --git a/...ration/fixtures/_error_/external-module-ref-non-string-3/snapshots/3-Alignment-Error.shot b/...ration/fixtures/_error_/external-module-ref-non-string-3/snapshots/3-Alignment-Error.shot
diff --git a/...claration/fixtures/_error_/external-module-ref-non-string/snapshots/1-TSESTree-Error.shot b/...claration/fixtures/_error_/external-module-ref-non-string/snapshots/1-TSESTree-Error.shot
diff --git a/...laration/fixtures/_error_/external-module-ref-non-string/snapshots/3-Alignment-Error.shot b/...laration/fixtures/_error_/external-module-ref-non-string/snapshots/3-Alignment-Error.shot
diff --git a/packages/ast-spec/src/special/TSExternalModuleReference/spec.ts b/packages/ast-spec/src/special/TSExternalModuleReference/spec.ts
@@ -1,9 +1,8 @@
 import type { AST_NODE_TYPES } from '../../ast-node-types';
 import type { BaseNode } from '../../base/BaseNode';
-import type { Expression } from '../../unions/Expression';
+import type { StringLiteral } from '../../expression/literal/StringLiteral/spec';
 
 export interface TSExternalModuleReference extends BaseNode {
   type: AST_NODE_TYPES.TSExternalModuleReference;
-  // TODO(#1852) - this must be a string
-  expression: Expression;
+  expression: StringLiteral;
 }
diff --git a/packages/ast-spec/tests/fixtures-with-differences-errors.shot b/packages/ast-spec/tests/fixtures-with-differences-errors.shot
diff --git a/packages/eslint-plugin-internal/src/rules/no-typescript-default-import.ts b/packages/eslint-plugin-internal/src/rules/no-typescript-default-import.ts
@@ -1,5 +1,4 @@
 import type { TSESTree } from '@typescript-eslint/utils';
-import { AST_NODE_TYPES } from '@typescript-eslint/utils';
 
 import { createRule } from '../util';
 
@@ -62,10 +61,7 @@ export default createRule({
         node: TSESTree.TSExternalModuleReference,
       ): void {
         const parent = node.parent as TSESTree.TSImportEqualsDeclaration;
-        if (
-          node.expression.type === AST_NODE_TYPES.Literal &&
-          node.expression.value === 'typescript'
-        ) {
+        if (node.expression.value === 'typescript') {
           context.report({
             node,
             messageId: 'noTSDefaultImport',

diff --git a/packages/eslint-plugin/src/rules/no-restricted-imports.ts b/packages/eslint-plugin/src/rules/no-restricted-imports.ts
@@ -312,10 +312,7 @@ export default createRule<Options, MessageIds>({
         node: TSESTree.TSImportEqualsDeclaration,
       ): void {
         if (
-          node.moduleReference.type ===
-            AST_NODE_TYPES.TSExternalModuleReference &&
-          node.moduleReference.expression.type === AST_NODE_TYPES.Literal &&
-          typeof node.moduleReference.expression.value === 'string'
+          node.moduleReference.type === AST_NODE_TYPES.TSExternalModuleReference
         ) {
           const synthesizedImport = {
             ...node,

diff --git a/packages/eslint-plugin/tests/rules/no-require-imports.test.ts b/packages/eslint-plugin/tests/rules/no-require-imports.test.ts
@@ -51,10 +51,6 @@ require('remark-preset-prettier');
       code: "import pkg = require('some-package');",
       options: [{ allow: ['^some-package$'] }],
     },
-    {
-      code: 'import pkg = require(`some-package`);',
-      options: [{ allow: ['^some-package$'] }],
-    },
   ],
   invalid: [
     {
@@ -207,16 +203,5 @@ var lib5 = require?.('lib5'),
         },
       ],
     },
-    {
-      code: 'import pkg = require(`./package.json`);',
-      options: [{ allow: ['^some-package$'] }],
-      errors: [
-        {
-          line: 1,
-          column: 14,
-          messageId: 'noRequireImports',
-        },
-      ],
-    },
   ],
 });
diff --git a/packages/typescript-estree/src/convert.ts b/packages/typescript-estree/src/convert.ts
@@ -3107,6 +3107,9 @@ export class Converter {
         );
       }
       case SyntaxKind.ExternalModuleReference: {
+        if (node.expression.kind !== SyntaxKind.StringLiteral) {
+          this.#throwError(node.expression, 'String literal expected.');
+        }
         return this.createNode<TSESTree.TSExternalModuleReference>(node, {
           type: AST_NODE_TYPES.TSExternalModuleReference,
           expression: this.convertChild(node.expression),