Skip to content

docs: add docs for using rule tester with node:test #9049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 11, 2024

Conversation

NotWoods
Copy link
Contributor

@NotWoods NotWoods commented May 6, 2024

PR Checklist

Overview

Adds an example of RuleTester with the node:test runner, which uses Node's CLI flags to import the setup file (as there's no equivalent test runner specific flag). The test file will get imported for every test, but that should be fine since we just copy some variables.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @NotWoods!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

nx-cloud bot commented May 6, 2024

Copy link

netlify bot commented May 6, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 73e066e
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/663f1fb8f0e54e0008512f87
😎 Deploy Preview https://deploy-preview-9049--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Exkaleburx Exkaleburx mentioned this pull request May 6, 2024
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes May 9, 2024
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🙌

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label May 9, 2024
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@auvred auvred merged commit 3f766b7 into typescript-eslint:main May 11, 2024
@NotWoods NotWoods deleted the node-test-rule-tester branch May 12, 2024 18:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Add RuleTester docs for working with node:test
3 participants