Skip to content

test(typescript-estree): add unit tests for inferSingleRun function #8710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

test(typescript-estree): add unit tests for inferSingleRun function #8710

wants to merge 6 commits into from

Conversation

y-hsgw
Copy link
Contributor

@y-hsgw y-hsgw commented Mar 18, 2024 •
edited
Loading

PR Checklist

Overview

add Testcase in typescript-estree's inferSingleRun .

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @y-hsgw!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Mar 18, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 321dfe3
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/660f938efd903000081ac595
😎 Deploy Preview https://deploy-preview-8710--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 18, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 321dfe3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@y-hsgw y-hsgw changed the title Add unit tests for typescript-estree's inferSingleRun test: typescript-estree function in typescript-estree add TestCase Mar 18, 2024
@y-hsgw y-hsgw changed the title test: typescript-estree function in typescript-estree add TestCase test: add TestCase for typescript-estree function in typescript-estree Mar 19, 2024
@y-hsgw y-hsgw changed the title test: add TestCase for typescript-estree function in typescript-estree test: add TestCase for inferSingleRun function in typescript-estree Mar 19, 2024
auvred
auvred requested changes Mar 22, 2024
View reviewed changes
@auvred auvred added the awaiting response Issues waiting for a reply from the OP or another party label Mar 22, 2024
@auvred auvred changed the title test: add TestCase for inferSingleRun function in typescript-estree test(typescript-estree): add unit tests for inferSingleRun function Mar 26, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.14%. Comparing base (716b783) to head (baf2f1f).
Report is 8 commits behind head on main.

❗ Current head baf2f1f differs from pull request most recent head 321dfe3. Consider uploading reports for the commit 321dfe3 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8710      +/-   ##
==========================================
+ Coverage   88.02%   88.14%   +0.12%     
==========================================
  Files         405      404       -1     
  Lines       14089    14089              
  Branches     4125     4125              
==========================================
+ Hits        12402    12419      +17     
+ Misses       1382     1369      -13     
+ Partials      305      301       -4
Flag Coverage Δ
unittest 88.14% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

@y-hsgw y-hsgw closed this by deleting the head repository Apr 17, 2024
@y-hsgw y-hsgw mentioned this pull request Apr 18, 2024
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@auvred auvred auvred requested changes

Assignees
No one assigned
Labels
awaiting response Issues waiting for a reply from the OP or another party
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Add unit tests for typescript-estree's inferSingleRun
2 participants
@y-hsgw @auvred