Skip to content

fix(eslint-plugin): [prefer-optional-chain] handle binary expressions in negated or #5992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 16, 2022
Merged

fix(eslint-plugin): [prefer-optional-chain] handle binary expressions in negated or #5992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
de139e8
fix/issue5991-fix-prefer-optional-chain-BinaryExpression-in-negated-or
Nov 15, 2022
126404b
Merge branch 'main' into fix/issue5991-fix-prefer-optional-chain-Bina…
Nov 15, 2022
a9f1a05
CR
Nov 15, 2022
22be168
Merge branch 'main' into fix/issue5991-fix-prefer-optional-chain-Bina…
Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/eslint-plugin/src/rules/prefer-optional-chain.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,7 @@ export default util.createRule({

case AST_NODE_TYPES.Literal:
case AST_NODE_TYPES.TemplateLiteral:
case AST_NODE_TYPES.BinaryExpression:
propertyText = sourceCode.getText(node.property);
break;

Expand Down
2 changes: 2 additions & 0 deletions packages/eslint-plugin/tests/rules/prefer-optional-chain.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,8 @@ ruleTester.run('prefer-optional-chain', rule, {
'foo && foo[bar as string] && foo[bar as string].baz;',
'foo && foo[1 + 2] && foo[1 + 2].baz;',
'foo && foo[typeof bar] && foo[typeof bar].baz;',
'!foo[1 + 1] || !foo[1 + 2];',
'!foo[1 + 1] || !foo[1 + 1].foo;',
'!foo || !foo[bar as string] || !foo[bar as string].baz;',
'!foo || !foo[1 + 2] || !foo[1 + 2].baz;',
'!foo || !foo[typeof bar] || !foo[typeof bar].baz;',
Expand Down