Skip to content

fix(type-utils): add missing 'types' dependency to 'type-utils' #11383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2025
Merged

fix(type-utils): add missing 'types' dependency to 'type-utils' #11383

merged 1 commit into from
Jul 8, 2025
+2 −0

Conversation

mrginglymus
Copy link
Contributor

@mrginglymus mrginglymus commented Jul 8, 2025 •
edited
Loading

PR Checklist

Overview

#10670 added an import from @typescript-eslint/types to @typescript-eslint/type-utils. However, the former is not present in the latters dependencies so strict pacakge managers (e.g. yarn pnp) will throw an error.

This PR adds the dependency.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @mrginglymus!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jul 8, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit be8f3e4
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/686cc2e424c419000868de92
😎 Deploy Preview https://deploy-preview-11383--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 95 (🟢 up 6 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 8, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit be8f3e4

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 8s View ↗
nx run-many -t lint ✅ Succeeded 3m 13s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 2s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 9s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx run integration-tests:test ✅ Succeeded 5s View ↗
nx run generate-configs ✅ Succeeded 8s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-07-08 07:14:34 UTC

@mrginglymus mrginglymus changed the title fix(type-utils): Add missing 'types' dependency to 'type-utils' fix(type-utils): Add missing 'types' dependency to 'type-utils'. Jul 8, 2025
@mrginglymus mrginglymus changed the title fix(type-utils): Add missing 'types' dependency to 'type-utils'. fix(type-utils): add missing 'types' dependency to 'type-utils' Jul 8, 2025
bradzacher
bradzacher approved these changes Jul 8, 2025
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops thanks for this!

@bradzacher bradzacher merged commit 5c5e3d5 into typescript-eslint:main Jul 8, 2025
71 of 76 checks passed
@mrginglymus mrginglymus deleted the transitive-import branch July 8, 2025 09:41
@Silic0nS0ldier Silic0nS0ldier mentioned this pull request Jul 9, 2025
Merged
1 task
@hpedrorodrigues
Copy link

Hey 👋🏻

First of all, thanks for the project and this pull request.

Is there a chance you can release a new patch version with this fix? This is blocking the update to the latest minor version.

@bradzacher
Copy link
Member

It will release in a few days
https://typescript-eslint.io/users/releases

@jkowalleck jkowalleck mentioned this pull request Jul 12, 2025
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Transitive import of @typescript-eslint/types from @typescript-eslint/type-utils
3 participants
@mrginglymus @hpedrorodrigues @bradzacher