chore(website): show tsconfig parsing errors in tab #10991
Conversation
|
Thanks for the PR, @developer-bandi! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit a4d1fb9
☁️ Nx Cloud last updated this comment at |
|
maybe we should just extends fs to contain info about errors for specific files, with that we could change/swap what we display based on file that is selected? tsconfig is a file (model) in monaco, similar to any other file, and its cloned as vfs file |
If I understand correctly, you mean changing the type of markers to |
| .split('\n') | ||
| .map((message: string) => { |
There was a problem hiding this comment.
Do you have an example of a message that needs to be split? I've only been able to make versions with a single reported error at a time.
There was a problem hiding this comment.
I'm not sure if this is realistic, but I used split because I was able to generate two errors with the settings below.
{
"compilerOptions": {
"moduleResolution": "classic",
"resolveJsonModule": true,
"incremental": true,
"outFile": "dist/bundle.js"
}
}
JoshuaKGoldberg
added
the
awaiting response
…loper-bandi/typescript-eslint into feature/tscofing-view-error
github-actions
bot
removed
the
awaiting response
bradzacher
changed the title
kirkwaiblinger
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10991 +/- ##
=======================================
Coverage 90.84% 90.84%
=======================================
Files 501 501
Lines 50919 50919
Branches 8387 8387
=======================================
Hits 46256 46256
Misses 4648 4648
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
kirkwaiblinger
added
the
1 approval
JoshuaKGoldberg
merged commit 25728c2
into
typescript-eslint:main
PR Checklist
Overview
I'm trying to manage tsconfig errors with different markers and statuses.Because I couldn't integrate tsconfig errors into markers since markers change depending on editor changes, and I thought it was wrong to apply tsconfig where markers are created.treat in below comment, change marker type to
Record<TabType,ErrorGroup[]>