typescript-eslint · JoshuaKGoldberg · Dec 2, 2024 · Nov 25, 2024 · Nov 26, 2024 · Dec 2, 2024
diff --git a/packages/eslint-plugin/docs/rules/prefer-promise-reject-errors.mdx b/packages/eslint-plugin/docs/rules/prefer-promise-reject-errors.mdx
@@ -54,3 +54,26 @@ new Promise((resolve, reject) => {
 
 </TabItem>
 </Tabs>
+
+## Options
+
+This rule adds the following options:
+
+```ts
+interface Options {
+  /**
+   * Whether to always allow throwing values typed as `any`.
+   */
+  allowThrowingAny?: boolean;
+
+  /**
+   * Whether to always allow throwing values typed as `unknown`.
+   */
+  allowThrowingUnknown?: boolean;
+}
+
+const defaultOptions: Options = {
+  allowThrowingAny: false,
+  allowThrowingUnknown: false,
+};
+```
diff --git a/packages/eslint-plugin/src/rules/prefer-promise-reject-errors.ts b/packages/eslint-plugin/src/rules/prefer-promise-reject-errors.ts
@@ -6,6 +6,8 @@ import {
   createRule,
   getParserServices,
   isErrorLike,
+  isTypeAnyType,
+  isTypeUnknownType,
   isFunction,
   isIdentifier,
   isPromiseConstructorLike,
@@ -19,6 +21,8 @@ export type MessageIds = 'rejectAnError';
 export type Options = [
   {
     allowEmptyReject?: boolean;
+    allowThrowingAny?: boolean;
+    allowThrowingUnknown?: boolean;
   },
 ];
 
@@ -45,13 +49,25 @@ export default createRule<Options, MessageIds>({
             description:
               'Whether to allow calls to `Promise.reject()` with no arguments.',
           },
+          allowThrowingAny: {
+            type: 'boolean',
+            description:
+              'Whether to always allow throwing values typed as `any`.',
+          },
+          allowThrowingUnknown: {
+            type: 'boolean',
+            description:
+              'Whether to always allow throwing values typed as `unknown`.',
+          },
         },
       },
     ],
   },
   defaultOptions: [
     {
       allowEmptyReject: false,
+      allowThrowingAny: false,
+      allowThrowingUnknown: false,
     },
   ],
   create(context, [options]) {
@@ -61,6 +77,15 @@ export default createRule<Options, MessageIds>({
       const argument = callExpression.arguments.at(0);
       if (argument) {
         const type = services.getTypeAtLocation(argument);
+
+        if (options.allowThrowingAny && isTypeAnyType(type)) {
+          return;
+        }
+
+        if (options.allowThrowingUnknown && isTypeUnknownType(type)) {
+          return;
+        }
+
         if (
           isErrorLike(services.program, type) ||
           isReadonlyErrorLike(services.program, type)

diff --git a/packages/eslint-plugin/tests/rules/prefer-promise-reject-errors.test.ts b/packages/eslint-plugin/tests/rules/prefer-promise-reject-errors.test.ts
@@ -25,6 +25,20 @@ ruleTester.run('prefer-promise-reject-errors', rule, {
         },
       ],
     },
+    {
+      code: `
+        declare const someAnyValue: any;
+        Promise.reject(someAnyValue);
+      `,
+      options: [{ allowThrowingAny: true, allowThrowingUnknown: false }],
+    },
+    {
+      code: `
+        declare const someUnknownValue: unknown;
+        Promise.reject(someUnknownValue);
+      `,
+      options: [{ allowThrowingAny: false, allowThrowingUnknown: true }],
+    },
     'Promise.reject(new Error());',
     'Promise.reject(new TypeError());',
     "Promise.reject(new Error('foo'));",
@@ -281,6 +295,20 @@ ruleTester.run('prefer-promise-reject-errors', rule, {
         foo.reject(t);
       }
     `,
+    {
+      code: `
+        declare const someAnyValue: any;
+        Promise.reject(someAnyValue);
+      `,
+      options: [{ allowThrowingAny: true, allowThrowingUnknown: true }],
+    },
+    {
+      code: `
+        declare const someUnknownValue: unknown;
+        Promise.reject(someUnknownValue);
+      `,
+      options: [{ allowThrowingAny: true, allowThrowingUnknown: true }],
+    },
   ],
   invalid: [
     {
@@ -1467,5 +1495,55 @@ function fun<T extends number>(t: T): void {
         },
       ],
     },
+    {
+      code: `
+        declare const someAnyValue: any;
+        Promise.reject(someAnyValue);
+      `,
+      errors: [
+        {
+          messageId: 'rejectAnError',
+          type: AST_NODE_TYPES.CallExpression,
+        },
+      ],
+      options: [{ allowThrowingAny: false, allowThrowingUnknown: true }],
+    },
+    {
+      code: `
+        declare const someUnknownValue: unknown;
+        Promise.reject(someUnknownValue);
+      `,
+      errors: [
+        {
+          messageId: 'rejectAnError',
+          type: AST_NODE_TYPES.CallExpression,
+        },
+      ],
+      options: [{ allowThrowingAny: true, allowThrowingUnknown: false }],
+    },
+    {
+      code: `
+        declare const someUnknownValue: unknown;
+        Promise.reject(someUnknownValue);
+      `,
+      errors: [
+        {
+          messageId: 'rejectAnError',
+          type: AST_NODE_TYPES.CallExpression,
+        },
+      ],
+    },
+    {
+      code: `
+        declare const someAnyValue: any;
+        Promise.reject(someAnyValue);
+      `,
+      errors: [
+        {
+          messageId: 'rejectAnError',
+          type: AST_NODE_TYPES.CallExpression,
+        },
+      ],
+    },
   ],
 });
diff --git a/packages/eslint-plugin/tests/schema-snapshots/prefer-promise-reject-errors.shot b/packages/eslint-plugin/tests/schema-snapshots/prefer-promise-reject-errors.shot