Skip to content

docs(website): open in playground button should not cover text #10019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 27, 2024
Merged

docs(website): open in playground button should not cover text #10019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8599287
style: increase padding-bottom to prevent overlap
mdm317 Sep 19, 2024
6ce2f1a
Revert "style: increase padding-bottom to prevent overlap"
mdm317 Sep 20, 2024
492c3c1
fix : add padding bottom only when playground button is visible
mdm317 Sep 20, 2024
671aad4
Merge branch 'main' into fix/button-should-not-cover-text
mdm317 Sep 20, 2024
93bde0b
Revert "fix : add padding bottom only when playground button is visible"
mdm317 Sep 20, 2024
bfd32c6
fix : Increase the padding if the length of the last line of code exc…
mdm317 Sep 20, 2024
87e5875
Merge branch 'fix/button-should-not-cover-text' of https://github.com…
mdm317 Sep 20, 2024
3378137
fix : add padding when codeblocks has playground button
mdm317 Sep 24, 2024
cd03e39
Merge branch 'main' into fix/button-should-not-cover-text
mdm317 Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/website/src/theme/CodeBlock/Content/String.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,17 @@ export default function CodeBlockString({
const showLineNumbers =
showLineNumbersProp ?? containsLineNumbers(metastring);

const copiedCode = code
const codeLines = code
.split('\n')
.filter(
(c, i) =>
!(lineClassNames[i] as string[] | undefined)?.includes(
'code-block-removed-line',
),
)
.join('\n');
);
const copiedCode = codeLines.join('\n');
const lastLineOfCodeLength = codeLines.at(-1)?.length ?? 0;
const needsMorePadding = lastLineOfCodeLength > 50;

const eslintrcHash = parseEslintrc(metastring);

Expand Down Expand Up @@ -90,6 +92,9 @@ export default function CodeBlockString({
<code
className={clsx(
styles.codeBlockLines,
eslintrcHash &&
needsMorePadding &&
styles.codeBlockLinesMorePadding,
showLineNumbers && styles.codeBlockLinesWithNumbering,
)}
>
Expand Down
5 changes: 5 additions & 0 deletions packages/website/src/theme/CodeBlock/Content/styles.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@
padding: var(--ifm-pre-padding);
}

.codeBlockLinesMorePadding {
padding: var(--ifm-pre-padding) var(--ifm-pre-padding)
calc(var(--ifm-pre-padding) * 2.5);
}

.codeBlockLinesWithNumbering {
display: table;
padding: var(--ifm-pre-padding) 0;
Expand Down
Loading