-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Closed
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuebugSomething isn't workingSomething isn't workinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-plugin
Description
Before You File a Bug Report Please Confirm You Have Done The Following...
- I have tried restarting my IDE and the issue persists.
- I have updated to the latest version of the packages.
- I have searched for related issues and found none that matched my issue.
- I have read the FAQ and my problem is not listed.
Playground Link
Repro Code
The minimal reproduction is as follows:
declare class SomeClass {
someMethod(methodParam: any); // ❌ `'methodParam' is already declared in the upper scope`
}
function methodParam() { }
If, however, function methodParam
is instead a var
, let
or const
declaration, the ESLint error is not triggered.
Quite a few more examples of this strange behavior are in the playground link.
ESLint Config
module.exports = {
parser: "@typescript-eslint/parser",
rules: {
"@typescript-eslint/no-shadow": "error"
},
};
tsconfig
Expected Result
The error should always be reported or not reported no matter with what type of declaration the name of the parameter inside an ambient declaration clashes.
I personally can't tell whether it's technically shadowing or not. Perhaps having an option to treat clashes between real and ambient declarations' names as shadowing issues could be the solution.
Actual Result
The current behavior seems inconsistent to me.
Additional Info
No response
Metadata
Metadata
Assignees
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuebugSomething isn't workingSomething isn't workinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-plugin