-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat:Update model id to command-a-03-2025, deprecate safety instr param #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes in this pull request update the model identifier in the Changes
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
src/libs/Cohere/openapi.yaml (4)
155-161
: Review Safety Instruction Description References
The safety instruction parameter’s description now provides comprehensive details (including fallback and default modes). However, it still refers to “Command R 08-2024” and “Command R+ 08-2024”. If the intention is to migrate entirely to the new model (i.e.command-a-03-2025
), please double-check whether these version references should be updated or explicitly noted as legacy.
851-857
: Deprecation of Custom Playground Preset Parameter
The custom playground preset parameter is now marked as deprecated and its description clarifies its usage. Please verify that the double apostrophe in preset''s parameters is intentional for proper YAML escaping. If not, consider switching to a block-style literal for enhanced readability.
7433-7439
: Safety Instruction Parameter Details and Deprecation Consideration
The safety instruction parameter’s description now details the available modes and their behaviors. In light of the PR summary noting that this parameter is deprecated, please ensure that adeprecated: true
flag is added if that is the intended change.
7831-7849
: Tools Integration Code Samples Updated
The tools integration examples (for TypeScript, Python, Java, Go, and cURL) have been revised to use the new model identifier. Ensure that function definitions and parameter schema details (for functions likequery_daily_sales_report
andquery_product_catalog
) remain aligned with the overall API design and the new model’s specifications.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (11)
src/libs/Cohere/Generated/Cohere.CohereClient.Chat.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.CohereClient.Chatv2.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.ICohereClient.Chat.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.ICohereClient.Chatv2.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.IModelsClient.GetModel.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.Models.ChatRequest.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.Models.ChatRequestSafetyMode.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.Models.Chatv2Request.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.Models.Chatv2RequestSafetyMode.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.Models.ClassifyRequest.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.ModelsClient.GetModel.g.cs
is excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/Cohere/openapi.yaml
(13 hunks)
🔇 Additional comments (9)
src/libs/Cohere/openapi.yaml (9)
116-122
: Clarify Model Parameter Description
The updated description for the model field now explicitly explains the expected value and directs users to the Cohere models documentation. Please verify that the URL and phrasing remain consistent with current guidelines.
419-424
: Consistent Update of Detokenize Code Samples
The code samples for the detokenize functionality (including both synchronous and asynchronous Python examples) have been updated to usemodel="command-a-03-2025"
. These changes are consistent and accurately reflect the new model identifier.
2107-2122
: Detokenize Examples Updated for New Model
All detokenize code samples across various SDKs (TypeScript, Python sync/async, Java, and cURL) are now usingcommand-a-03-2025
. The updates are applied correctly and uniformly.
6790-6796
: Schema Example Alignment
The schema example now reflects the updated model identifier (example: command-a-03-2025
), which is consistent with the rest of the specification changes.
7313-7331
: Tokenization Code Samples Consistency
Tokenization examples in TypeScript, Python, Java, Node.js, and cURL have been updated to usecommand-a-03-2025
. The changes are consistent, and no issues were observed.
7406-7412
: Updated Chat Model Parameter Description
The description now points to the Cohere v2 docs for compatibility information. This refresh ensures users can locate up‐to‐date documentation. Please verify that this change is consistently reflected across all similar parameters.
7520-7548
: v2-Beta Chat Examples Updated
The v2-beta examples across various SDKs (including TypeScript, Python, Go, Java, cURL) now usemodel: "command-a-03-2025"
. The examples are consistent and clearly structured. Please validate these against the latest API specifications.
7561-7579
: Chat with Documents Examples Refined
The code samples illustrating chat requests that include documents are updated to use the new model identifier. The integration and sample payloads look correct and consistent.
7703-7721
: Streaming Chat Examples Are Consistent
All streaming chat code examples across TypeScript, Python, Java, Go, and cURL have been updated to reflectcommand-a-03-2025
. The stream handling and client usage appear to follow best practices.
Summary by CodeRabbit