Update Dockerfile FROM command to use non-ambiguous container sources #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@idelsink thanks for the PR, it sounds great to me. But unfortunately the PR at the moment has some conflicts. Would you be able to rebase and fix the issues? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This will set a non-ambiguous container source for the Dockerfile(s) used in this project. This reduces issues when using non-docker tooling that rely on full container sources. This increases not only verbosity but it also reduces the changes of exploits as explained in the following redhat post Container image short names
See also: #641
I have:
make test.How has this code been tested
I've tested it locally by running
make testand was able to build the containers myself usingmake docker.