Disallow use of sqlite sessions, but pass through others #993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
approved these changes
Jul 24, 2025
There was a problem hiding this comment.
LGTM. So we fail the task, since it's something they can fix in their code. And we know they're in workflow code because we check that at the top of our Runner.run. Will it make sense at some point for our plugin to give them a custom workflow-compatible in-memory session that they can use?
|
There's definitely a possibility for our plugin to provide session implementations. Whether we do that via memory, large payload, or something else is still pending. Sessions were only added to the agents SDK a few weeks ago, so it isn't in plan yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Checklist
Closes
How was this tested: