Skip to content

💥 Move tracing uuids to use a separate Random from the workflow seed #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 25, 2025
Merged

💥 Move tracing uuids to use a separate Random from the workflow seed #992

merged 7 commits into from
Jul 25, 2025

Conversation

tconley1428
Copy link
Contributor

What was changed

Why?

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@tconley1428 tconley1428 requested a review from a team as a code owner July 24, 2025 17:16
@tconley1428 tconley1428 changed the title Move tracing uuids to use a separate Random from the workflow seed 💥 Move tracing uuids to use a separate Random from the workflow seed Jul 24, 2025
jssmith
jssmith reviewed Jul 25, 2025
View reviewed changes
Copy link
Contributor

@jssmith jssmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it does the right thing. I'd suggest adding some comments to explain why we introduced this mechanism.

jssmith
jssmith reviewed Jul 25, 2025
View reviewed changes
@tconley1428 tconley1428 merged commit fc564c4 into main Jul 25, 2025
37 of 40 checks passed
@tconley1428 tconley1428 deleted the openai/trace_random branch July 25, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jssmith jssmith jssmith left review comments

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tconley1428 @cretz @jssmith