Skip to content

Add exception catching logic to model activity #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 22, 2025
Merged

Add exception catching logic to model activity #982

merged 7 commits into from
Jul 22, 2025

Conversation

tconley1428
Copy link
Contributor

@tconley1428 tconley1428 commented Jul 21, 2025 •
edited
Loading

What was changed

Disable retries in the openai client layer. Add retryability handling for the model invocation.

Why?

Gives user more control of retry behavior.

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@tconley1428 tconley1428 marked this pull request as ready for review July 21, 2025 21:28
@tconley1428 tconley1428 requested a review from a team as a code owner July 21, 2025 21:28
cretz
cretz approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking

@tconley1428 tconley1428 merged commit fe82b07 into main Jul 22, 2025
25 of 28 checks passed
@tconley1428 tconley1428 deleted the openai/retry_takeover branch July 22, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tconley1428 @cretz