Skip to content

Making raise on cancellation the default #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 2, 2025
Merged

Making raise on cancellation the default #935

merged 5 commits into from
Jul 2, 2025

Conversation

tconley1428
Copy link
Contributor

What was changed

Set RAISE_ON_CANCELLING_COMPLETED_ACTIVITY when not replaying, and reraise by default.

Why?

Prevents the swallowing of some activity cancellations

Checklist

  1. Closes [Bug] Workflow cancellation can be swallowed #620

  2. How was this tested:
    Modified tests

  3. Any docs updates needed?

@tconley1428 tconley1428 requested a review from a team as a code owner July 1, 2025 21:45
cretz
cretz approved these changes Jul 2, 2025
View reviewed changes
cretz
cretz reviewed Jul 2, 2025
View reviewed changes
@tconley1428 tconley1428 merged commit 633b90c into main Jul 2, 2025
24 of 28 checks passed
@tconley1428 tconley1428 deleted the swallowed_cancellation_default branch July 2, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Workflow cancellation can be swallowed
2 participants
@tconley1428 @cretz