Skip to content

Adding named params to openai activity configurations #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 25, 2025

Conversation

tconley1428
Copy link
Contributor

What was changed

Use named parameters instead of kwargs

Why?

Better documentation and ease of use

Checklist

  1. Closes Add named parameters to OpenAI APIs #911

  2. How was this tested:
    Existing openai tests

  3. Any docs updates needed?

@tconley1428 tconley1428 requested a review from a team as a code owner June 23, 2025 18:19
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since this is all experimental and will be moot if we have a plugin approach anyways

@tconley1428 tconley1428 merged commit 4cf0697 into main Jun 25, 2025
43 of 48 checks passed
@tconley1428 tconley1428 deleted the openai_named_params branch June 25, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add named parameters to OpenAI APIs
2 participants