-
Notifications
You must be signed in to change notification settings - Fork 79
OpenAI Agents financial research and reasoning examples #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: jssmith/openai-samples-reorg
Are you sure you want to change the base?
OpenAI Agents financial research and reasoning examples #226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
. (moved to easily replyable comment, can't delete this unfortunately)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, the top-level of openai_agents
has all of the samples mashed together as one project at the top level dir. I think it makes the addition of this as a subdir a bit confusing. I wonder if we should move the current sample set into a subdir (e.g. "simple" or something) or make each sample its own dir as we are doing with these newer ones.
EDIT: I now see #221 will fix this, thanks! Can disregard this comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a little concerned we are adding lots of OpenAI sample code with no tests to confirm it continues to work. Granted I know this is unfortunately OpenAI's approach to samples, but ideally we can have some test somewhere. We have other samples where we have done this and it comes back to bite us hard when people report it stops working and we have to scramble (this is the case with the Sentry sample which has now remained broken for a long time).
(just adding this general comment, deferring code review to Dan/Tim)
What was changed
Ported financial research and reasoning examples from OpenAI Agents SDK.
Why?
Checklist
Closes
How was this tested: