fix[Windows]: Close log writer before removing files to avoid deletion issue (#631) #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…log on shutdown On Windows, deleting an open log file fails because it's still held by the process. This commit updates PidFile.Remove() to explicitly close the log writer if open Fixes symfony-cli#631
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
It ensures the log file is properly closed (via logWriter.Close()) when stopping a process on Windows, avoiding file lock issues.
###Why is it needed?
On Windows, when running symfony serve -d, the .log file stays locked after symfony server:stop, preventing cleanup and deletion.
How to reproduce the issue
How this fix works
OS affected
✅ Windows only
🚫 Linux/macOS not affected