[Form] Adding disabled option docs #2114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding inherited options for all form types
|
|
||
| .. include:: /reference/forms/types/options/read_only.rst.inc | ||
|
|
||
| .. include:: /reference/forms/types/options/disabled.rst.inc No newline at end of file |
There was a problem hiding this comment.
I don't think it is usefull to describe all inherit properties of the hidden field type, they don't make sense because the type is hidden.
weaverryan
added a commit
that referenced
this pull request
Jan 27, 2013
[Form] Adding disabled option docs
|
Nice work Sebastian! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As said in #2096, the docs are missing the
disabledoption which got introduced in 2.1.I added the missing inheritance documentation and added a versionadd tag to both the
read_onlyand thedisabledoption describing the change.