[Mime] Document the DKIM signer #13816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
reviewed
Jun 15, 2020
|
|
||
| // first argument: string with the contents or the absolute path of the private key | ||
| // second and third arguments: the domain name and "selector" used to perform a DNS lookup | ||
| // (the selector is a string used to point to a specific DKIM public key record in your DNS) |
There was a problem hiding this comment.
The first argument is the same as openssl_pkey_get_private (openssl_pkey_get_private), so it's either the private key itself or a path that starts with file://
There was a problem hiding this comment.
Thanks for reviewing this! Fixed in b731bd2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you can see in https://en.wikipedia.org/wiki/DomainKeys_Identified_Mail, DKIM is a pretty complex standard that defines lots of options, terminology and concepts.
In this doc I only mention some of them very slightly, because we assume that the reader of "Symfony DKIM signer docs" already knows what DKIM is and what does it require.