Deprecated the NumberToLocalizedStringTransformer constants #13654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
requested changes
May 11, 2020
carsonbot
added
Status: Needs Work
Status: Needs Review
and removed
Status: Needs Review
Status: Needs Work
labels
|
Christian, thanks for the fixes! I've also reworded the last paragraph. |
xabbuh
approved these changes
May 11, 2020
xabbuh
reviewed
May 11, 2020
wouterj
reviewed
May 12, 2020
| option is a constant on the :class:`Symfony\\Component\\Form\\Extension\\Core\\DataTransformer\\NumberToLocalizedStringTransformer`: | ||
| If a submitted number needs to be rounded (based on the `scale`_ option), you | ||
| have several configurable options for that rounding. Each option is a constant | ||
| on the ``\NumberFormatter`` class: |
There was a problem hiding this comment.
What about doing :phpclass:`NumberFormatter` here?
There was a problem hiding this comment.
Yes! Done in af24efa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13646.