[Console] Fix undefined offset when formatting namespace suggestions #9624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -515,8 +515,8 @@ public function findNamespace($namespace) | |||
| } | |||
|
|
|||
| $exact = in_array($namespace, $namespaces, true); | |||
| if (1 < count($namespaces) && !$exact) { | |||
| throw new \InvalidArgumentException(sprintf('The namespace "%s" is ambiguous (%s).', $namespace, $this->getAbbreviationSuggestions($namespaces))); | |||
| if (count($namespaces) > 1 && !$exact) { | |||
There was a problem hiding this comment.
Can you revert the condition change?
There was a problem hiding this comment.
@fabpot this change makes the condition consistent with the other one in this class:
if (count($commands) > 1 && !$exact) {
$suggestions = $this->getAbbreviationSuggestions(array_values($commands));
throw new \InvalidArgumentException(sprintf('Command "%s" is ambiguous (%s).', $name, $suggestions));
}There was a problem hiding this comment.
Sorry, that was to be coherent with the method find
fabpot
added a commit
that referenced
this pull request
Nov 27, 2013
…ggestions (GromNaN) This PR was submitted for the master branch but it was merged into the 2.4 branch instead (closes #9624). Discussion ---------- [Console] Fix undefined offset when formatting namespace suggestions [`preg_grep`](http://www.php.net/manual/en/function.preg-grep.php) returns an array indexed using the keys from the input array. `array_values` is used in the method `find`, but was missing in `findNamespace`. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #9614 | License | MIT | Doc PR | n/a Edit: should be merged to 2.4 Commits ------- f5c4011 [Console] Fix undefined offset when formatting namespace suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preg_grepreturns an array indexed using the keys from the input array.array_valuesis used in the methodfind, but was missing infindNamespace.Edit: should be merged to 2.4