Skip to content

[Filesystem] Mirror should keep the original symlink target and not the ... #9213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

COil
Copy link
Contributor

@COil COil commented Oct 4, 2013

...real path

When having a link that is already in a linked directory, the mirror function set the mirrored link with the realpath and not the original target directory of the symlink.

…he real path

When having a link that is already in a linked directory, the mirror function set the mirrored link with the realpath and not the original target directory of the symlink.
@COil
Copy link
Contributor Author

COil commented Oct 30, 2013

@fabpot Any change to have this little fix merged ?

@cordoval
Copy link
Contributor

this PR was pre @fabbot-io era, so need the table PR prensent http://symfony.com/doc/current/contributing/code/patches.html#rebase-your-patch and also probably a failing test describing behavior

@cordoval
Copy link
Contributor

@COil please close it

@COil COil closed this Dec 27, 2013
@COil
Copy link
Contributor Author

COil commented Dec 27, 2013

@cordoval Done.

fabpot added a commit that referenced this pull request Dec 27, 2013
This PR was merged into the 2.3 branch.

Discussion
----------

#9866 [Filesystem] Fixed mirror for symlinks

| Q             | A
| ------------- | ---
| Bug fix?      | [yes]
| New feature?  | [no]
| BC breaks?    | [no]
| Deprecations? | [no]
| Tests pass?   | [yes]
| Fixed tickets | [#9866]
| License       | MIT
| Doc PR        | [NA]

Check the original ticket for the full description and how to reproduce.

The initial PR #9213 was closed.

Commits
-------

d136555 [Filesystem] Fixed mirror for symlinks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants