Skip to content

[HttpFoundation] Add support for QUERY method #61175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GaryPEGEOT
Copy link
Contributor

Q A
Branch? 7.4
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #60521
License MIT

@nicolas-grekas
Copy link
Member

Race condition? #61173

@stof
Copy link
Member

stof commented Jul 21, 2025

Note that this implementation of HttpCache is broken, as it ignores the URI in the cache key. So #61173 is a better implementation.

public function testQueryRequestAreCacheable()
{
$this->setNextResponse(200, ['Cache-Control' => 'public, s-maxage=3600']);
$this->request('QUERY', content: '{"foo": "bar"}');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using named parameters in tests is a no-go. Tests should use the API covered by our BC promise, as that helps detecting unintentional BC breaks in some cases (if we have to make unexpected changes in tests so that they work). And parameter names are not covered by our BC promise in Symfony (except for attribute constructors)

@GaryPEGEOT
Copy link
Contributor Author

Race condition? #61173

Didn't see the pr, i'll close mine

@GaryPEGEOT GaryPEGEOT closed this Jul 21, 2025
@GaryPEGEOT GaryPEGEOT deleted the feat/query-method-support branch July 21, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for QUERY method
4 participants