[HttpFoundation] Add support for QUERY method #61175
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GaryPEGEOT
commented
Jul 21, 2025
GaryPEGEOT
commented
| Q | A |
|---|---|
| Branch? | 7.4 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Issues | Fix #60521 |
| License | MIT |
|
Race condition? #61173 |
|
Note that this implementation of HttpCache is broken, as it ignores the URI in the cache key. So #61173 is a better implementation. |
stof
reviewed
Jul 21, 2025
| public function testQueryRequestAreCacheable() | ||
| { | ||
| $this->setNextResponse(200, ['Cache-Control' => 'public, s-maxage=3600']); | ||
| $this->request('QUERY', content: '{"foo": "bar"}'); |
There was a problem hiding this comment.
using named parameters in tests is a no-go. Tests should use the API covered by our BC promise, as that helps detecting unintentional BC breaks in some cases (if we have to make unexpected changes in tests so that they work). And parameter names are not covered by our BC promise in Symfony (except for attribute constructors)
Didn't see the pr, i'll close mine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.