[Semaphore] Enabled usage of EVALSHA and LOAD SCRIPT over regular EVAL
#61162
+117
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santysisi
force-pushed
the
feature/redis-semaphore-evalsha
branch
from
e02c705 to
2de307d
Compare
santysisi
changed the title
EVALSHA and LOAD SCRIPT over regular EVAL
|
Hi 👋, I think the erros in the tests isn't relevant in the context of this PR. |
santysisi
force-pushed
the
feature/redis-semaphore-evalsha
branch
from
2de307d to
4afc680
Compare
nicolas-grekas
approved these changes
Jul 21, 2025
|
Thank you @santysisi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Semaphore component to use
EVALSHAinstead ofEVALwhen evaluating Lua scripts, following the same approach introduced in a previous PR for the Lock component. Reusing the cachedSHAimproves performance and avoids sending the full script each time.