[DoctrineBridge] Prevent idle connection listener from running on subrequest #61120
+21
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryuk
changed the title
nicolas-grekas
approved these changes
Jul 15, 2025
src/Symfony/Bridge/Doctrine/Middleware/IdleConnection/Listener.php
Outdated
Show resolved
Hide resolved
dmitryuk
force-pushed
the
7.3-doctrine-idle-listener-fix
branch
from
bd72428 to
d961acc
Compare
dmitryuk
requested review from
xabbuh,
lyrixx,
yceruto,
welcoMattic,
kbond,
chalasr,
dunglas,
OskarStark and
jderusse
as code owners
Do you want to change base branch to 7.2 ? |
nicolas-grekas
force-pushed
the
7.3-doctrine-idle-listener-fix
branch
from
d961acc to
3d9d99a
Compare
|
I took care of it. Thanks @dmitryuk! |
lyrixx
reviewed
Jul 15, 2025
| @@ -29,6 +30,9 @@ public function __construct( | |||
|
|
|||
| public function onKernelRequest(RequestEvent $event): void | |||
| { | |||
| if (HttpKernelInterface::MAIN_REQUEST !== $event->getRequestType()) { | |||
There was a problem hiding this comment.
Possible, but the same logic, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR #53214 has a bug.
Story: