-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[DoctrineBridge] Prevent idle connection listener from running on subrequest #61120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DoctrineBridge] Prevent idle connection listener from running on subrequest #61120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For 7.2 I'd say
src/Symfony/Bridge/Doctrine/Middleware/IdleConnection/Listener.php
Outdated
Show resolved
Hide resolved
bd72428
to
d961acc
Compare
Do you want to change base branch to 7.2 ? |
d961acc
to
3d9d99a
Compare
I took care of it. Thanks @dmitryuk! |
@@ -29,6 +30,9 @@ public function __construct( | |||
|
|||
public function onKernelRequest(RequestEvent $event): void | |||
{ | |||
if (HttpKernelInterface::MAIN_REQUEST !== $event->getRequestType()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually use isMainRequest()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible, but the same logic, thanks
Original PR #53214 has a bug.
Story: