[HttpKernel][Security] Refactor: use getAttributes with argument
#61112
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santysisi
force-pushed
the
refactor/use-getAttributes-arg
branch
from
c529f91 to
7e65f8f
Compare
carsonbot
changed the title
getAttributes with argumentgetAttributes with argument
santysisi
force-pushed
the
refactor/use-getAttributes-arg
branch
from
7e65f8f to
aa5c19a
Compare
stof
reviewed
Jul 15, 2025
src/Symfony/Component/HttpKernel/EventListener/CacheAttributeListener.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/EventListener/CacheAttributeListener.php
Outdated
Show resolved
Hide resolved
santysisi
force-pushed
the
refactor/use-getAttributes-arg
branch
from
aa5c19a to
6769c9a
Compare
|
Hi 👋 Thanks so much to both of you for your comments! 😊 |
|
Thank you @santysisi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored code to consistently use
$event->getAttributes($className)instead of accessing the full array. This simplifies attribute retrieval and improves readability.Reference