[WebProfilerBundle] Add blank-target to AJAX request links #61032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, works for me. But that makes me wonder: what about always opening the toolbar in an iframe/popup? That'd allow preserving the state all the time + might make the experience smoother? /cc @javiereguiluz also |
|
@nicolas-grekas I think this should be an option to be honest Opening a link in a new tab is a touch/key/click away from anyone… whereas « cancelling » a target blank isnt :/ Also, this is not the défaut behaviour of the browser and may impact accessibility (No hard opinion here, just to bring another vision here) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, clicking on a link to a profiled AJAX request in the profiler opens the details in the same browser tab. If the user navigates back, the request history is lost.
This PR adds the
target="_blankattribute to these links, so the detailed information opens in a new tab. This preserves the profiler state in the original tab.