Skip to content

[WebProfilerBundle] Add blank-target to AJAX request links #61032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 7.4
Choose a base branch
from

Conversation

barmax
Copy link

@barmax barmax commented Jul 3, 2025

Q A
Branch? 7.4
Bug fix? no
New feature? yes
Deprecations? no
License MIT
image

Currently, clicking on a link to a profiled AJAX request in the profiler opens the details in the same browser tab. If the user navigates back, the request history is lost.

This PR adds the target="_blank attribute to these links, so the detailed information opens in a new tab. This preserves the profiler state in the original tab.

@nicolas-grekas
Copy link
Member

Thanks, works for me. But that makes me wonder: what about always opening the toolbar in an iframe/popup? That'd allow preserving the state all the time + might make the experience smoother? /cc @javiereguiluz also

@smnandre
Copy link
Member

@nicolas-grekas I think this should be an option to be honest

Opening a link in a new tab is a touch/key/click away from anyone… whereas « cancelling » a target blank isnt :/

Also, this is not the défaut behaviour of the browser and may impact accessibility

(No hard opinion here, just to bring another vision here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants