Skip to content

[Cache] Add PdoTagAwareAdapter #58296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: 7.4
Choose a base branch
from
+843 −474
Open

[Cache] Add PdoTagAwareAdapter #58296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
aa98410
Created foundation for further discussion
Toflar Sep 17, 2024
3e55967
Added changelog entry
Toflar Sep 17, 2024
c8dc32e
CS
Toflar Sep 17, 2024
4904b06
CS
Toflar Sep 17, 2024
8bc548b
Implemented the rest of the drivers and todos
Toflar Sep 18, 2024
28812ef
CS
Toflar Sep 18, 2024
cc7178a
Split adapters
Toflar Sep 18, 2024
a2b7817
CS
Toflar Sep 18, 2024
60a715e
Update changelog
Toflar Sep 18, 2024
293e865
Cleanup
Toflar Sep 18, 2024
4628c49
Cleanup
Toflar Sep 18, 2024
2c2663a
Cleanup
Toflar Sep 19, 2024
b67a05a
Cleanup
Toflar Sep 19, 2024
a7494f6
Addressed feedback
Toflar Sep 19, 2024
ce6e16c
Addressed feedback
Toflar Sep 19, 2024
820cf33
Apply suggestions from code review
Toflar Sep 20, 2024
49d24d1
Make tag table information configurable
Toflar Sep 20, 2024
16ed6ec
CS
Toflar Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Symfony/Component/Cache/Adapter/AbstractTagAwareAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ abstract class AbstractTagAwareAdapter implements TagAwareAdapterInterface, TagA
use AbstractAdapterTrait;
use ContractsTrait;

private const TAGS_PREFIX = "\1tags\1";
protected const TAGS_PREFIX = "\1tags\1";

protected function __construct(string $namespace = '', int $defaultLifetime = 0)
{
Expand Down Expand Up @@ -168,7 +168,7 @@ protected function doDeleteYieldTags(array $ids): iterable
public function commit(): bool
{
$ok = true;
$byLifetime = (self::$mergeByLifetime)($this->deferred, $expiredIds, $this->getId(...), self::TAGS_PREFIX, $this->defaultLifetime);
$byLifetime = (self::$mergeByLifetime)($this->deferred, $expiredIds, $this->getId(...), static::TAGS_PREFIX, $this->defaultLifetime);
$retry = $this->deferred = [];

if ($expiredIds) {
Expand Down Expand Up @@ -244,7 +244,7 @@ public function deleteItems(array $keys): bool
try {
foreach ($this->doDeleteYieldTags(array_values($ids)) as $id => $tags) {
foreach ($tags as $tag) {
$tagData[$this->getId(self::TAGS_PREFIX.$tag)][] = $id;
$tagData[$this->getId(static::TAGS_PREFIX.$tag)][] = $id;
}
}
} catch (\Exception) {
Expand Down Expand Up @@ -283,7 +283,7 @@ public function invalidateTags(array $tags): bool

$tagIds = [];
foreach (array_unique($tags) as $tag) {
$tagIds[] = $this->getId(self::TAGS_PREFIX.$tag);
$tagIds[] = $this->getId(static::TAGS_PREFIX.$tag);
}

try {
Expand Down
Loading
Loading